Support scheduling Cloud Agent on master nodes #164
Merged
+56
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simu
reviewed
Jul 7, 2023
DebakelOrakel
force-pushed
the
feat/schedule-on-master
branch
from
d72611a to
91ee54a
Compare
|
@simu Do you by chance have insight, what jsonnet linter is unhappy whit? |
diff --git a/component/main.jsonnet b/component/main.jsonnet
index fa73d86..1672148 100644
--- a/component/main.jsonnet
+++ b/component/main.jsonnet
@@ -10,7 +10,7 @@ local params = inv.parameters.appuio_cloud;
local isOpenshift = std.startsWith(inv.parameters.facts.distribution, 'openshift');
local namespaceLabels = (
if isOpenshift then { 'openshift.io/cluster-monitoring': 'true' }
- else { 'SYNMonitoring': 'main' }
+ else { SYNMonitoring: 'main' }
) + params.namespaceLabels;
local namespaceAnnotations = (
if isOpenshift then { 'openshift.io/node-selector': '' } |
DebakelOrakel
force-pushed
the
feat/schedule-on-master
branch
from
91ee54a to
4b9ffcf
Compare
DebakelOrakel
force-pushed
the
feat/schedule-on-master
branch
from
4b9ffcf to
2e0a333
Compare
simu
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.
The PR has a meaningful description that sums up the change. It will be
linked in the changelog.
bug,enhancement,documentation,change,breaking,dependencyas they show up in the changelog.